feat(Freek): add presence #9014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theusaf
requested changes
Dec 27, 2024
theusaf
approved these changes
Dec 29, 2024
Bas950
reviewed
Dec 30, 2024
websites/F/Freek/metadata.json
Outdated
| "manga" | ||
| ], | ||
| "iframe": true, | ||
| "iFrameRegExp": ".*", |
There was a problem hiding this comment.
Are you able to use a more narrow regex?
There was a problem hiding this comment.
I'm not really sure what it iframe regex is. Is it just limiting the domain sources of the iframe?
There was a problem hiding this comment.
Yes, right now .* (meaning anything), will make the iframe.js script load into all iframes, regardless of URL.
It would be nice if you could limit it to a certain domain or path for example, so it doesn't load into Google Analytics iframe for example.
theusaf
added
the
inactive
auto-merge was automatically disabled
January 4, 2025 05:22
Head branch was pushed to by a user without write access
theusaf
removed
the
inactive
theusaf
approved these changes
Jan 4, 2025
Bas950
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr implements the following:
Support for current pages:
Unsupported (coming soon):
Acknowledgements
yarn formatScreenshots
Watching a movie
Watching a tv show
Searching
Exploring
Private browsing
History
Manga